Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and recipes to reflect new Promise-oriented del #1220

Merged
merged 1 commit into from
Aug 31, 2015

Conversation

wbinnssmith
Copy link
Contributor

Pending sindresorhus/del#29 and sindresorhus/vinyl-paths#3. Do not merge yet.

This updates the gulp readme to reflect an upcoming version of del that returns a promise rather than receives a callback. It ends up cleaning its usage through gulp quite nicely since tasks can return promises to complete them \o/

// You can use multiple globbing patterns as you would with `gulp.src`
del(['build'], cb);
return del(['build']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth noting that del can accept a single string in these kinds of cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I explicitly added an array here because I noticed people kept calling del multiple times instead of using an array 🤦

@yocontra
Copy link
Member

Will merge when released

sindresorhus added a commit that referenced this pull request Aug 31, 2015
Update readme and recipes to reflect new Promise-oriented `del`
@sindresorhus sindresorhus merged commit 5a2ec1b into gulpjs:master Aug 31, 2015
@sindresorhus
Copy link
Contributor

Landed as both referenced modules have been updated.

@wbinnssmith
Copy link
Contributor Author

@sindresorhus
Copy link
Contributor

687474703a2f2f74636c686f73742e636f6d2f36763641355a392e676966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants